Skip to content

[fix](variable persist) fix regression test test_mtmv #58869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
Dec 11, 2025
Merged

[fix](variable persist) fix regression test test_mtmv #58869

starocean999 merged 1 commit into from
Dec 11, 2025

Conversation

@feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Dec 9, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #58031

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei feiniaofeiafei force-pushed the fix_variable_persist_test branch from 680de0a to cea1895 Compare December 9, 2025 12:51
@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Dec 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 9, 2025

TPC-H: Total hot run time: 36190 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cea1895a470850af10f3b6c9db319b1711f3369f, data reload: false

------ Round 1 ----------------------------------
q1	17593	5016	4886	4886
q2	2044	350	251	251
q3	10173	1305	718	718
q4	10223	880	320	320
q5	7540	2272	1881	1881
q6	195	172	140	140
q7	1002	853	723	723
q8	9349	1431	1116	1116
q9	6958	5322	5317	5317
q10	6844	2397	1996	1996
q11	546	307	295	295
q12	662	724	582	582
q13	17786	3681	3068	3068
q14	289	287	274	274
q15	597	522	511	511
q16	946	916	886	886
q17	716	803	520	520
q18	7630	7219	7206	7206
q19	1112	966	616	616
q20	414	361	252	252
q21	4193	4045	3674	3674
q22	1053	1014	958	958
Total cold run time: 107865 ms
Total hot run time: 36190 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4968	4913	4938	4913
q2	351	403	326	326
q3	2127	2716	2287	2287
q4	1298	1733	1296	1296
q5	4763	4780	4446	4446
q6	263	175	125	125
q7	2017	1984	1794	1794
q8	2660	2472	2561	2472
q9	7433	7541	7502	7502
q10	3073	3332	3064	3064
q11	596	511	487	487
q12	715	806	629	629
q13	3573	4011	3291	3291
q14	289	297	290	290
q15	558	529	530	529
q16	917	921	898	898
q17	1193	1515	1450	1450
q18	8032	7622	7213	7213
q19	848	807	826	807
q20	1880	2051	1827	1827
q21	4626	4367	4153	4153
q22	1076	1019	956	956
Total cold run time: 53256 ms
Total hot run time: 50755 ms

@doris-robot
Copy link

doris-robot commented Dec 9, 2025

TPC-DS: Total hot run time: 181645 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cea1895a470850af10f3b6c9db319b1711f3369f, data reload: false

query5	4845	613	479	479
query6	334	230	228	228
query7	4246	456	275	275
query8	303	254	252	252
query9	8781	2643	2644	2643
query10	540	388	341	341
query11	15349	14950	14570	14570
query12	179	116	115	115
query13	1263	527	398	398
query14	6048	3330	3103	3103
query14_1	2951	2948	2957	2948
query15	209	197	180	180
query16	856	483	487	483
query17	1117	725	620	620
query18	2588	447	350	350
query19	244	239	210	210
query20	128	122	115	115
query21	221	140	115	115
query22	4134	4088	3830	3830
query23	16629	16319	15886	15886
query23_1	16039	16207	15973	15973
query24	7380	1669	1227	1227
query24_1	1234	1244	1265	1244
query25	583	510	478	478
query26	1255	284	163	163
query27	2737	472	314	314
query28	4463	2150	2121	2121
query29	795	535	438	438
query30	314	245	219	219
query31	832	712	611	611
query32	77	69	68	68
query33	538	335	286	286
query34	931	907	544	544
query35	804	807	723	723
query36	859	917	839	839
query37	129	95	82	82
query38	3928	3856	3795	3795
query39	742	748	716	716
query39_1	709	722	697	697
query40	233	143	124	124
query41	69	63	65	63
query42	106	111	108	108
query43	440	433	410	410
query44	1322	788	754	754
query45	193	188	184	184
query46	879	977	621	621
query47	1660	1693	1638	1638
query48	320	323	249	249
query49	612	477	374	374
query50	666	295	234	234
query51	3879	3858	3819	3819
query52	108	108	98	98
query53	328	348	310	310
query54	300	266	249	249
query55	78	75	75	75
query56	303	315	307	307
query57	1146	1132	1065	1065
query58	291	263	258	258
query59	2409	2356	2304	2304
query60	317	317	293	293
query61	162	158	150	150
query62	686	679	613	613
query63	329	297	300	297
query64	4958	1308	1019	1019
query65	4053	3941	3948	3941
query66	1439	441	337	337
query67	15201	15238	14869	14869
query68	4813	1038	742	742
query69	508	342	318	318
query70	1097	995	958	958
query71	356	306	296	296
query72	6091	4996	5233	4996
query73	691	599	315	315
query74	8736	8757	8643	8643
query75	3549	3567	3158	3158
query76	3908	1157	767	767
query77	523	387	319	319
query78	9485	9543	8893	8893
query79	1755	880	596	596
query80	894	650	552	552
query81	521	269	241	241
query82	430	129	106	106
query83	257	257	239	239
query84	261	128	100	100
query85	916	531	480	480
query86	413	302	305	302
query87	4003	4030	3911	3911
query88	3212	2283	2276	2276
query89	460	424	392	392
query90	2144	164	158	158
query91	179	169	147	147
query92	76	68	68	68
query93	1617	912	570	570
query94	541	307	281	281
query95	585	390	304	304
query96	590	467	208	208
query97	2576	2652	2599	2599
query98	216	198	188	188
query99	1250	1330	1213	1213
Total cold run time: 260474 ms
Total hot run time: 181645 ms

@doris-robot
Copy link

doris-robot commented Dec 9, 2025

ClickBench: Total hot run time: 27.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cea1895a470850af10f3b6c9db319b1711f3369f, data reload: false

query1	0.05	0.05	0.04
query2	0.10	0.05	0.05
query3	0.25	0.09	0.09
query4	1.60	0.11	0.11
query5	0.27	0.25	0.27
query6	1.18	0.67	0.63
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.57	0.51	0.52
query10	0.55	0.56	0.55
query11	0.15	0.10	0.11
query12	0.15	0.12	0.13
query13	0.61	0.60	0.61
query14	1.00	0.99	1.00
query15	0.81	0.79	0.82
query16	0.42	0.39	0.41
query17	1.03	1.01	1.00
query18	0.22	0.22	0.21
query19	1.92	1.85	1.90
query20	0.02	0.01	0.01
query21	15.44	0.30	0.14
query22	4.75	0.06	0.04
query23	16.08	0.29	0.10
query24	1.45	0.64	0.32
query25	0.08	0.08	0.05
query26	0.15	0.13	0.13
query27	0.06	0.05	0.05
query28	3.17	1.22	1.03
query29	12.64	3.94	3.24
query30	0.28	0.14	0.12
query31	2.83	0.63	0.40
query32	3.23	0.56	0.48
query33	2.99	3.08	3.14
query34	16.91	5.20	4.50
query35	4.58	4.57	4.57
query36	0.65	0.50	0.51
query37	0.11	0.07	0.07
query38	0.08	0.04	0.04
query39	0.04	0.04	0.03
query40	0.18	0.15	0.13
query41	0.08	0.04	0.03
query42	0.04	0.03	0.02
query43	0.05	0.03	0.03
Total cold run time: 96.85 s
Total hot run time: 27.45 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

PR approved by anyone and no changes requested.

@feiniaofeiafei feiniaofeiafei force-pushed the fix_variable_persist_test branch from cea1895 to 69350f0 Compare December 11, 2025 02:49
@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Dec 11, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 11, 2025

TPC-H: Total hot run time: 36496 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69350f016bcc98cdfbbde7e510223211122c98c9, data reload: false

------ Round 1 ----------------------------------
q1	17635	4176	4083	4083
q2	2031	347	246	246
q3	10159	1332	742	742
q4	10241	900	315	315
q5	7530	2121	1984	1984
q6	188	166	135	135
q7	999	830	705	705
q8	9365	1474	1137	1137
q9	7044	5399	5451	5399
q10	6834	2391	1955	1955
q11	534	322	304	304
q12	643	754	589	589
q13	17771	3675	2999	2999
q14	303	304	275	275
q15	577	514	505	505
q16	949	915	864	864
q17	712	803	521	521
q18	7529	7651	8175	7651
q19	1111	982	627	627
q20	421	374	247	247
q21	4766	4187	4276	4187
q22	1113	1026	1069	1026
Total cold run time: 108455 ms
Total hot run time: 36496 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4238	4209	4203	4203
q2	321	405	314	314
q3	2318	2991	2456	2456
q4	1364	1830	1442	1442
q5	4626	4753	4414	4414
q6	216	166	122	122
q7	2003	1932	1945	1932
q8	2939	2497	2529	2497
q9	7592	7543	7536	7536
q10	3081	3254	2816	2816
q11	567	496	494	494
q12	682	795	598	598
q13	3670	3881	2984	2984
q14	262	271	255	255
q15	533	487	485	485
q16	854	886	829	829
q17	1149	1442	1358	1358
q18	7311	7213	7038	7038
q19	837	785	815	785
q20	1908	1952	1809	1809
q21	4746	4395	4334	4334
q22	1077	1038	992	992
Total cold run time: 52294 ms
Total hot run time: 49693 ms

@doris-robot
Copy link

doris-robot commented Dec 11, 2025

TPC-DS: Total hot run time: 182394 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 69350f016bcc98cdfbbde7e510223211122c98c9, data reload: false

query5	4434	620	460	460
query6	338	250	230	230
query7	4212	475	277	277
query8	307	244	249	244
query9	8767	2595	2569	2569
query10	491	389	323	323
query11	15167	14896	14908	14896
query12	185	119	113	113
query13	1271	514	407	407
query14	6024	3262	3194	3194
query14_1	2845	2845	2872	2845
query15	212	197	189	189
query16	892	494	495	494
query17	1166	709	616	616
query18	2451	447	349	349
query19	231	235	208	208
query20	122	117	112	112
query21	224	138	118	118
query22	3955	4388	4083	4083
query23	16607	16058	16032	16032
query23_1	16039	16143	16239	16143
query24	7370	1695	1217	1217
query24_1	1232	1246	1265	1246
query25	587	510	466	466
query26	1258	275	177	177
query27	2752	481	309	309
query28	4468	2153	2143	2143
query29	839	585	474	474
query30	321	251	219	219
query31	863	719	624	624
query32	77	71	67	67
query33	539	335	279	279
query34	916	898	543	543
query35	793	830	733	733
query36	870	941	822	822
query37	129	95	77	77
query38	3876	3786	3749	3749
query39	767	724	733	724
query39_1	698	708	689	689
query40	222	135	120	120
query41	82	62	63	62
query42	105	104	104	104
query43	424	436	404	404
query44	1314	755	767	755
query45	192	193	182	182
query46	877	980	618	618
query47	1716	1713	1632	1632
query48	323	340	249	249
query49	631	434	398	398
query50	659	296	223	223
query51	3789	3803	3766	3766
query52	106	110	97	97
query53	331	351	289	289
query54	287	255	261	255
query55	78	75	74	74
query56	303	295	303	295
query57	1150	1139	1082	1082
query58	263	254	249	249
query59	2390	2503	2354	2354
query60	328	323	292	292
query61	159	163	164	163
query62	702	664	618	618
query63	330	294	299	294
query64	5108	1340	1041	1041
query65	4009	3954	3936	3936
query66	1464	437	325	325
query67	15271	15060	14756	14756
query68	7810	1014	738	738
query69	498	349	304	304
query70	1062	966	970	966
query71	368	313	285	285
query72	6036	5204	5147	5147
query73	729	655	315	315
query74	8812	8822	8724	8724
query75	3576	3532	3138	3138
query76	3929	1134	763	763
query77	525	393	295	295
query78	9386	9521	8893	8893
query79	1525	868	610	610
query80	688	660	562	562
query81	490	272	230	230
query82	211	132	106	106
query83	264	253	234	234
query84	254	129	106	106
query85	933	528	461	461
query86	329	294	287	287
query87	4045	4027	3984	3984
query88	4222	2293	2247	2247
query89	457	423	390	390
query90	2234	165	155	155
query91	183	172	145	145
query92	83	63	70	63
query93	1468	952	556	556
query94	483	309	276	276
query95	577	389	312	312
query96	592	487	213	213
query97	2616	2627	2514	2514
query98	216	195	193	193
query99	1284	1283	1215	1215
Total cold run time: 262680 ms
Total hot run time: 182394 ms

@doris-robot
Copy link

doris-robot commented Dec 11, 2025

ClickBench: Total hot run time: 27.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69350f016bcc98cdfbbde7e510223211122c98c9, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.05	0.04
query3	0.24	0.09	0.09
query4	1.60	0.11	0.11
query5	0.26	0.25	0.26
query6	1.18	0.66	0.63
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.50	0.50
query10	0.56	0.55	0.56
query11	0.14	0.11	0.11
query12	0.15	0.11	0.12
query13	0.64	0.61	0.61
query14	0.99	0.99	1.00
query15	0.80	0.80	0.79
query16	0.42	0.40	0.39
query17	1.06	1.08	1.08
query18	0.23	0.22	0.21
query19	1.82	1.90	1.81
query20	0.02	0.01	0.02
query21	15.44	0.30	0.13
query22	4.67	0.06	0.04
query23	15.99	0.30	0.10
query24	1.09	0.59	0.43
query25	0.09	0.08	0.05
query26	0.14	0.13	0.13
query27	0.06	0.05	0.04
query28	3.85	1.23	1.02
query29	12.61	3.96	3.21
query30	0.27	0.14	0.12
query31	2.81	0.61	0.40
query32	3.24	0.55	0.45
query33	3.05	2.99	2.99
query34	16.95	5.22	4.56
query35	4.59	4.55	4.54
query36	0.66	0.50	0.48
query37	0.10	0.06	0.07
query38	0.08	0.04	0.03
query39	0.04	0.03	0.03
query40	0.17	0.15	0.13
query41	0.10	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 97 s
Total hot run time: 27.4 s

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Dec 11, 2025

run feut

@feiniaofeiafei
Copy link
Contributor Author

feiniaofeiafei commented Dec 11, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 11, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 11, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@starocean999 starocean999 merged commit 13b7314 into apache:master Dec 11, 2025
26 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@feiniaofeiafei @nagisa-kunhah
[fix](variable persist) fix regression test test_mtmv (apache#58869)
38c988e
feiniaofeiafei added a commit to feiniaofeiafei/doris that referenced this pull request Dec 15, 2025
@feiniaofeiafei
[fix](variable persist) fix regression test test_mtmv (apache#58869)
bccb0d9
@feiniaofeiafei feiniaofeiafei mentioned this pull request Dec 15, 2025
Merged
yiguolei pushed a commit to feiniaofeiafei/doris that referenced this pull request Dec 17, 2025
@feiniaofeiafei @yiguolei
[fix](variable persist) fix regression test test_mtmv (apache#58869)
9802547
yiguolei pushed a commit that referenced this pull request Dec 18, 2025
@feiniaofeiafei
branch-4.0:[fix](variable persist) fix regression test test_mtmv #58869…
eb2352a 
… (#59034)

picked from #58869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

+1 more reviewer

@seawinde seawinde seawinde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@feiniaofeiafei @Thearas @doris-robot @hello-stephen @morrySnow @seawinde @yiguolei @starocean999