branch-4.0: [fix](regr) Use Youngs-Cramer for REGR_SLOPE/INTERCEPT to align with PG #55940 #58920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PG (#55940) This PR reimplements `REGR_SLOPE` and `REGR_INTERCEPT` using the Youngs–Cramer algorithm to align with PostgreSQL. It also extends `AggregateFunctionRegrData<T>` so it can be reused by all `REGR_*` functions (`SXX`, `SYY`, `SXY`, `R2`, etc.). ```sql -- Copy from `regression-test/suites/query_p0/aggregate/support_type/regr_slope/regr_slope.groovy` -- dataset (PostgreSQL) drop table if exists d_table; create table d_table ( k1 int, k2 int not null, k3 bigint, col_tinyint smallint, col_smallint smallint, col_int int, col_bigint bigint, col_largeint numeric(38,0), col_float real, col_double double precision ); insert into d_table values (1, 1, 1, 100, 10000, 1000000, 10000000000, 100000000000000000000, 3.14, 2.718281828), (2, 2, 2, 101, 10001, 1000001, 10000000001, 100000000000000000001, 6.28, 3.141592653), (3, 3, 3, 102, 10002, 1000002, 10000000002, 100000000000000000002, 9.42, 1.618033988); select regr_slope(col_tinyint, col_smallint) from d_table; -- 1.0 select regr_slope(col_smallint, col_int) from d_table; -- 1.0 select regr_slope(col_int, col_bigint) from d_table; -- 1.0 select regr_slope(col_bigint, col_largeint) from d_table; -- <null> select regr_slope(col_largeint, col_float) from d_table; -- 0.0 select regr_slope(col_float, col_double) from d_table; -- -2.7928921351549283 select regr_slope(col_double, col_tinyint) from d_table; -- -0.5501239200000003 select regr_intercept(col_tinyint, col_smallint) from d_table; -- -9900.0 select regr_intercept(col_smallint, col_int) from d_table; -- -990000.0 select regr_intercept(col_int, col_bigint) from d_table; -- -9999000000.0 select regr_intercept(col_bigint, col_largeint) from d_table; -- <null> select regr_intercept(col_largeint, col_float) from d_table; -- 1e+20 select regr_intercept(col_float, col_double) from d_table; -- 13.241664047161668 select regr_intercept(col_double, col_tinyint) from d_table; -- 58.055152076333364 ```
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Dec 11, 2025
github-actions
bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #55940