[chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness#59019
Draft
gavinchou wants to merge 4 commits intoapache:masterfrom
Draft
[chore](cloud) Change range iterator check pattern from do...while() to while() to get better robustness#59019gavinchou wants to merge 4 commits intoapache:masterfrom
gavinchou wants to merge 4 commits intoapache:masterfrom
Conversation
…o while() to get better robustness The original implementation of do...while() check is not extensible for retry if we failed to do the first `txn->get()` in the while loop. It will end with referencing null pointer at the check `while (it->more())`
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
changed the title
Contributor
Author
|
run buildall |
Contributor
Author
|
run cloud_ut |
w41ter
previously approved these changes
Dec 15, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Dec 26, 2025
…apache#59020 (apache#6203) fix first txn->get ends up with null pointer partial pick apache#59019
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 30, 2026
…>get() failed apache#59019 (apache#59020) fix first txn->get ends up with null pointer partial pick apache#59019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original implementation of do...while() check is not extensible for retry if we failed to do the first
txn->get()in the while loop. It will end with referencing null pointer at the checkwhile (it->more()), and the original pattern is easily misused/copied in a scenario needs retry.No need to add new tests, the changes are covered by existing tests.