[Resource Tag][Step1] Support setting tags for BE nodes, and support create table with specified tags#5903
Closed
morningman wants to merge 3 commits intoapache:masterfrom
Closed
[Resource Tag][Step1] Support setting tags for BE nodes, and support create table with specified tags#5903morningman wants to merge 3 commits intoapache:masterfrom
morningman wants to merge 3 commits intoapache:masterfrom
Conversation
4002c33 to
6934847
Compare
Contributor
Author
|
This PR is covered by #6203 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Step 1 of #5902
This CL mainly changes:
Support setting tags for BE nodes:
And for compatibility, all BE nodes will be set a "default" tag: "tag.location": "default".
Create a new class
ReplicaAllocationto replace the previousreplication_num.ReplicaAllocationrepresents the allocation of the replicas of a tablet. It contains a map fromTag to number of replicas.
For example, if user set a table's replication num to 3, it will be converted to a ReplicaAllocation
like: "tag.location.default" : "3", which means the tablet will have 3 replicas and all of them will be
allocated in BE nodes with tag "default";
Support create table with replication allocation:
Also support set replica allocation for dynamic tables, and modify replica allocation at runtime.
For compatibility, user can still set "replication_num" = "3", and it will be automatically converted to:
"tag.location.default" = "3".
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...