Skip to content

branch-4.0: [fix](core) fix core if hll_from_base64 input invalid #59106 #59147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Dec 19, 2025
Merged

branch-4.0: [fix](core) fix core if hll_from_base64 input invalid #59106 #59147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion be/src/vec/functions/function_hll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@ class FunctionHllFromBase64 : public IFunction {
doris::HyperLogLog hll;
if (!hll.deserialize(decoded_slice)) {
return Status::RuntimeError(
fmt::format("hll_from_base64 decode failed: base64: {}", src_str));
fmt::format("hll_from_base64 decode failed: base64: {}",
StringRef(src_str, src_size).to_string()));
} else {
res.emplace_back(std::move(hll));
}
Expand Down
5 changes: 5 additions & 0 deletions regression-test/suites/query_p0/sql_functions/hll_functions/test_hll_functions.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,9 @@ suite("test_hll_functions") {
qt_const_select "select hll_to_base64(hll_empty());"
qt_const_select "select hll_to_base64(hll_hash('abc'));"
qt_const_select "select hll_to_base64(hll_hash(''));"

test {
sql """SELECT hll_from_base64(CAST('AgAAAAAAAABwAAAAAAAAAA==' AS VARCHAR(100))) AS result;"""
exception "[RUNTIME_ERROR]hll_from_base64 decode failed";
}
}
Loading