Skip to content

[fix](cache) always create data and index page cache to avoid null pointer #59266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
airborne12 merged 1 commit into from
Dec 23, 2025
Merged

[fix](cache) always create data and index page cache to avoid null pointer #59266

airborne12 merged 1 commit into from
Dec 23, 2025

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Dec 22, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Dec 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 22, 2025

TPC-H: Total hot run time: 36390 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bbf69511ee383870f00f8c1c755714c93a97c562, data reload: false

------ Round 1 ----------------------------------
q1	17614	4126	4038	4038
q2	1994	355	236	236
q3	10181	1320	754	754
q4	10220	874	316	316
q5	7529	2214	1966	1966
q6	190	174	137	137
q7	1034	871	738	738
q8	9409	1506	1176	1176
q9	7517	5386	5360	5360
q10	6850	2411	2002	2002
q11	526	332	307	307
q12	657	708	595	595
q13	17774	3687	3037	3037
q14	296	287	283	283
q15	612	531	523	523
q16	711	690	622	622
q17	691	838	496	496
q18	7418	7698	7852	7698
q19	1172	1047	643	643
q20	413	373	258	258
q21	4539	4355	4241	4241
q22	1196	1103	964	964
Total cold run time: 108543 ms
Total hot run time: 36390 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4416	4259	4307	4259
q2	340	415	366	366
q3	2547	2886	2592	2592
q4	1407	1939	1514	1514
q5	4555	4403	4517	4403
q6	224	205	150	150
q7	2103	1911	1814	1814
q8	2585	2816	2515	2515
q9	7560	7426	7541	7426
q10	3114	3131	2695	2695
q11	611	518	492	492
q12	651	688	587	587
q13	3269	3646	3011	3011
q14	263	283	264	264
q15	533	495	486	486
q16	614	662	611	611
q17	1105	1368	1409	1368
q18	7234	7234	7095	7095
q19	819	779	807	779
q20	1888	1943	1789	1789
q21	4631	4348	4114	4114
q22	1069	1018	970	970
Total cold run time: 51538 ms
Total hot run time: 49300 ms

@doris-robot
Copy link

doris-robot commented Dec 22, 2025

TPC-DS: Total hot run time: 179369 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bbf69511ee383870f00f8c1c755714c93a97c562, data reload: false

query5	4994	611	441	441
query6	324	228	220	220
query7	4251	475	270	270
query8	315	259	263	259
query9	8781	2530	2522	2522
query10	544	365	361	361
query11	15614	15174	14737	14737
query12	185	122	118	118
query13	1267	514	384	384
query14	6345	2950	2747	2747
query14_1	2620	2605	2624	2605
query15	215	197	176	176
query16	880	459	465	459
query17	1127	725	619	619
query18	2525	448	353	353
query19	250	235	205	205
query20	126	118	114	114
query21	227	144	117	117
query22	3961	3964	3942	3942
query23	16714	16325	15999	15999
query23_1	16085	16304	16251	16251
query24	7348	1656	1224	1224
query24_1	1223	1241	1243	1241
query25	578	521	456	456
query26	1254	278	170	170
query27	2725	467	319	319
query28	4476	2140	2125	2125
query29	822	584	475	475
query30	318	243	216	216
query31	841	722	627	627
query32	81	74	69	69
query33	549	350	297	297
query34	895	900	532	532
query35	768	799	763	763
query36	864	919	811	811
query37	124	91	75	75
query38	2961	3005	2939	2939
query39	777	745	740	740
query39_1	709	714	882	714
query40	224	143	120	120
query41	67	66	63	63
query42	112	108	115	108
query43	435	433	402	402
query44	1302	738	729	729
query45	192	193	182	182
query46	872	971	607	607
query47	1704	1730	1657	1657
query48	335	323	255	255
query49	640	469	347	347
query50	668	293	220	220
query51	3790	3877	3773	3773
query52	105	111	99	99
query53	319	351	295	295
query54	286	265	244	244
query55	79	83	72	72
query56	289	310	285	285
query57	1151	1163	1081	1081
query58	269	303	247	247
query59	2376	2538	2475	2475
query60	322	310	303	303
query61	166	158	156	156
query62	724	699	730	699
query63	338	297	293	293
query64	4916	1291	1014	1014
query65	4003	3973	3979	3973
query66	1451	431	317	317
query67	15313	15110	14815	14815
query68	8430	1023	729	729
query69	480	345	316	316
query70	1053	997	955	955
query71	398	300	286	286
query72	6008	4987	5026	4987
query73	701	640	308	308
query74	8604	8841	8679	8679
query75	3198	3154	2780	2780
query76	4018	1125	743	743
query77	577	392	298	298
query78	9456	9665	8818	8818
query79	1259	879	606	606
query80	694	672	557	557
query81	520	269	230	230
query82	204	130	103	103
query83	264	257	250	250
query84	260	116	109	109
query85	933	511	454	454
query86	378	293	274	274
query87	3261	3165	3124	3124
query88	3164	2264	2255	2255
query89	484	426	396	396
query90	2056	164	156	156
query91	179	167	144	144
query92	79	66	67	66
query93	1084	945	563	563
query94	454	308	280	280
query95	582	385	308	308
query96	587	459	214	214
query97	2279	2323	2229	2229
query98	223	199	205	199
query99	1337	1350	1314	1314
Total cold run time: 260651 ms
Total hot run time: 179369 ms

@doris-robot
Copy link

doris-robot commented Dec 22, 2025

ClickBench: Total hot run time: 27.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bbf69511ee383870f00f8c1c755714c93a97c562, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.09	0.09
query4	1.61	0.11	0.12
query5	0.28	0.26	0.25
query6	1.14	0.65	0.64
query7	0.03	0.03	0.02
query8	0.05	0.05	0.04
query9	0.56	0.50	0.50
query10	0.54	0.55	0.55
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	0.99	0.99	1.00
query15	0.84	0.80	0.82
query16	0.40	0.39	0.40
query17	1.09	1.04	1.03
query18	0.24	0.22	0.22
query19	1.95	1.81	1.82
query20	0.02	0.01	0.01
query21	15.44	0.28	0.14
query22	4.89	0.05	0.05
query23	16.17	0.29	0.11
query24	1.50	0.23	0.19
query25	0.11	0.07	0.06
query26	0.15	0.14	0.13
query27	0.06	0.05	0.05
query28	4.02	1.25	1.03
query29	12.61	4.08	3.24
query30	0.28	0.15	0.12
query31	2.83	0.63	0.39
query32	3.23	0.54	0.45
query33	2.97	3.03	3.00
query34	16.76	5.14	4.51
query35	4.55	4.59	4.61
query36	0.67	0.49	0.50
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 97.86 s
Total hot run time: 27.29 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 22, 2025

BE UT Coverage Report

Increment line coverage 100.00% (12/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.45% (18937/35431)
Line Coverage 39.31% (175503/446505)
Region Coverage 33.85% (135756/401106)
Branch Coverage 34.77% (58531/168354)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 22, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (12/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.30% (25040/34633)
Line Coverage 59.04% (262882/445228)
Region Coverage 53.98% (218796/405298)
Branch Coverage 55.46% (93684/168932)

csun5285
csun5285 approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei added usercase Important user case type label p0_c dev/4.0.x labels Dec 23, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

PR approved by anyone and no changes requested.

airborne12
airborne12 approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 2dace7a into apache:master Dec 23, 2025
35 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 23, 2025
@zzzxl1993
[fix](cache) always create data and index page cache to avoid null po…
d512060 
…inter (#59266)
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Merged
yiguolei pushed a commit that referenced this pull request Dec 23, 2025
@github-actions @zzzxl1993
branch-4.0: [fix](cache) always create data and index page cache to a…
df4b256 
…void null pointer #59266 (#59273)

Cherry-picked from #59266

Co-authored-by: zzzxl <yangsiyu@selectdb.com>
@yiguolei yiguolei mentioned this pull request Jan 23, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@yiguolei yiguolei yiguolei approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged p0_c reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zzzxl1993 @Thearas @doris-robot @hello-stephen @airborne12 @yiguolei @csun5285