branch-4.0: [fix](scanner) Make Scanner close() method thread-safe using atomic operations (#57436)#59605
Closed
suxiaogang223 wants to merge 1 commit intoapache:branch-4.0from
Closed
branch-4.0: [fix](scanner) Make Scanner close() method thread-safe using atomic operations (#57436)#59605suxiaogang223 wants to merge 1 commit intoapache:branch-4.0from
suxiaogang223 wants to merge 1 commit intoapache:branch-4.0from
Conversation
…perations (apache#57436) ### What problem does this PR solve? close: apache#56328 Problem Summary: The current close() method in Scanner class and its derived classes has thread safety issues in multi-threaded environments. Multiple threads may call close() simultaneously, leading to: 1. Race conditions: Multiple threads may check _is_closed status and execute close operations simultaneously 2. Double close: May cause resources to be released or cleaned up multiple times 3. Potential memory leaks or crash risks
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bp: #57436