Skip to content

Conversation

@feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Jan 7, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #31811

Problem Summary:
Before this pr:
The LogicalAggregate generated by MergeAggregate outputExpressions has duplicated column .
This bug will not lead to result wrong, will output the gby key 2 times in LogicalAggregate.
After this pr:
This pr fix this problem.
Now,

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@morrySnow
Copy link
Contributor

Please describe the specific error and its cause. Add the PR that introduced the issue to related PRs.

@doris-robot
Copy link

TPC-H: Total hot run time: 31999 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aa4ffd21b1c4f7f730325029c713a0008aba95f5, data reload: false

------ Round 1 ----------------------------------
q1	17622	4216	4055	4055
q2	2084	363	246	246
q3	10093	1273	711	711
q4	10209	833	316	316
q5	7546	2117	1857	1857
q6	191	172	140	140
q7	937	788	652	652
q8	9274	1378	1261	1261
q9	4888	4569	4610	4569
q10	6742	1786	1407	1407
q11	517	306	285	285
q12	681	738	595	595
q13	17788	3797	3076	3076
q14	285	316	272	272
q15	559	511	500	500
q16	677	685	633	633
q17	647	792	534	534
q18	6536	6424	6822	6424
q19	1143	1102	667	667
q20	413	394	256	256
q21	3240	2594	2503	2503
q22	1224	1090	1040	1040
Total cold run time: 103296 ms
Total hot run time: 31999 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4419	4207	4208	4207
q2	337	408	331	331
q3	2315	2838	2432	2432
q4	1411	1903	1482	1482
q5	4395	4223	4406	4223
q6	224	176	132	132
q7	1980	1883	1708	1708
q8	2506	2654	2409	2409
q9	7116	7310	7112	7112
q10	2487	2804	2289	2289
q11	581	483	458	458
q12	694	738	606	606
q13	3578	4083	3263	3263
q14	264	280	252	252
q15	528	492	485	485
q16	605	646	615	615
q17	1079	1224	1271	1224
q18	7570	7478	7351	7351
q19	842	868	845	845
q20	1888	2009	1863	1863
q21	4513	4278	4129	4129
q22	1071	1057	994	994
Total cold run time: 50403 ms
Total hot run time: 48410 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173666 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aa4ffd21b1c4f7f730325029c713a0008aba95f5, data reload: false

query5	4364	576	425	425
query6	326	221	213	213
query7	4222	452	258	258
query8	335	259	236	236
query9	8745	2648	2690	2648
query10	528	367	320	320
query11	15388	15211	14900	14900
query12	169	116	111	111
query13	1271	494	396	396
query14	5667	2927	2736	2736
query14_1	2579	2554	2573	2554
query15	211	208	171	171
query16	988	454	457	454
query17	1074	668	544	544
query18	2407	431	335	335
query19	222	212	189	189
query20	119	118	115	115
query21	219	138	122	122
query22	3980	4064	4104	4064
query23	16009	15961	15635	15635
query23_1	15530	15636	15548	15548
query24	7357	1547	1170	1170
query24_1	1194	1163	1187	1163
query25	527	434	392	392
query26	1237	258	154	154
query27	2777	433	292	292
query28	4584	2127	2150	2127
query29	752	564	441	441
query30	315	243	208	208
query31	776	622	554	554
query32	76	67	63	63
query33	533	334	272	272
query34	913	870	524	524
query35	756	803	707	707
query36	849	879	824	824
query37	132	91	79	79
query38	2733	2712	2586	2586
query39	779	747	760	747
query39_1	710	706	716	706
query40	215	134	113	113
query41	68	67	61	61
query42	107	98	99	98
query43	458	469	440	440
query44	1328	718	721	718
query45	187	185	173	173
query46	854	955	603	603
query47	1365	1457	1310	1310
query48	304	319	242	242
query49	593	413	324	324
query50	630	278	196	196
query51	3781	3837	3800	3800
query52	104	108	97	97
query53	299	321	267	267
query54	274	254	243	243
query55	79	72	68	68
query56	280	287	291	287
query57	1013	1025	949	949
query58	273	257	256	256
query59	2157	2054	2172	2054
query60	333	333	307	307
query61	196	196	182	182
query62	396	363	333	333
query63	295	268	275	268
query64	5051	1433	1111	1111
query65	3827	3715	3787	3715
query66	1482	440	319	319
query67	15282	16050	15136	15136
query68	4694	1014	714	714
query69	521	356	315	315
query70	1076	945	949	945
query71	353	302	280	280
query72	6124	3418	3472	3418
query73	756	710	295	295
query74	8792	8817	8627	8627
query75	2788	2807	2464	2464
query76	3803	1055	631	631
query77	527	363	267	267
query78	9863	10057	9236	9236
query79	929	893	588	588
query80	1168	555	462	462
query81	556	263	230	230
query82	380	144	116	116
query83	399	249	235	235
query84	258	122	99	99
query85	996	509	471	471
query86	394	321	318	318
query87	2850	2876	2787	2787
query88	3120	2224	2192	2192
query89	387	347	318	318
query90	1953	152	147	147
query91	169	165	143	143
query92	73	66	60	60
query93	970	879	531	531
query94	642	327	304	304
query95	582	340	359	340
query96	576	450	209	209
query97	2355	2350	2319	2319
query98	213	199	193	193
query99	609	591	494	494
Total cold run time: 251061 ms
Total hot run time: 173666 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aa4ffd21b1c4f7f730325029c713a0008aba95f5, data reload: false

query1	0.05	0.05	0.05
query2	0.11	0.05	0.04
query3	0.27	0.09	0.08
query4	1.60	0.12	0.11
query5	0.28	0.27	0.26
query6	1.14	0.66	0.66
query7	0.03	0.02	0.03
query8	0.06	0.03	0.04
query9	0.57	0.51	0.47
query10	0.56	0.55	0.56
query11	0.14	0.09	0.10
query12	0.14	0.12	0.12
query13	0.61	0.59	0.59
query14	0.96	0.96	0.94
query15	0.78	0.77	0.78
query16	0.39	0.42	0.42
query17	1.06	1.01	1.02
query18	0.24	0.22	0.21
query19	1.98	1.88	1.84
query20	0.02	0.01	0.02
query21	15.45	0.27	0.14
query22	5.18	0.05	0.05
query23	15.71	0.29	0.10
query24	1.45	0.66	1.03
query25	0.12	0.07	0.05
query26	0.15	0.14	0.14
query27	0.07	0.05	0.07
query28	5.28	1.08	0.88
query29	12.66	3.93	3.17
query30	0.28	0.14	0.11
query31	2.82	0.64	0.40
query32	3.24	0.57	0.46
query33	2.97	3.06	3.08
query34	16.87	5.08	4.48
query35	4.45	4.49	4.44
query36	0.67	0.50	0.49
query37	0.12	0.06	0.06
query38	0.08	0.05	0.03
query39	0.05	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 98.94 s
Total hot run time: 27.29 s

@feiniaofeiafei
Copy link
Contributor Author

run p0

@feiniaofeiafei
Copy link
Contributor Author

run vault_p0

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 6ac90f1 into apache:master Jan 8, 2026
42 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 8, 2026
Related PR: #31811

Problem Summary:
Before this pr:
The LogicalAggregate generated by MergeAggregate outputExpressions has
duplicated column .
This bug will not lead to result wrong, will output the gby key 2 times
in LogicalAggregate.
After this pr:
This pr fix this problem.
yiguolei pushed a commit that referenced this pull request Jan 12, 2026
Cherry-picked from #59629

Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Jan 13, 2026
Related PR: apache#31811

Problem Summary:
Before this pr:
The LogicalAggregate generated by MergeAggregate outputExpressions has
duplicated column .
This bug will not lead to result wrong, will output the gby key 2 times
in LogicalAggregate.
After this pr:
This pr fix this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants