Skip to content

branch-4.0: Fix: Ensure HUDI tables are processed correctly by throwing an error for incorrect PhysicalFileScan usage #59709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Jan 10, 2026
Merged

branch-4.0: Fix: Ensure HUDI tables are processed correctly by throwing an error for incorrect PhysicalFileScan usage #59709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d3e0b
Fix: Ensure HUDI tables are processed correctly by throwing an error …
suxiaogang223 Nov 27, 2025
abda678
fix build
suxiaogang223 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...e-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,13 @@ public PlanFragment visitPhysicalFileScan(PhysicalFileScan fileScan, PlanTransla
fileScan.getTableSample().get().sampleValue, fileScan.getTableSample().get().seek));
}
break;
case HUDI:
// HUDI table should be handled by visitPhysicalHudiScan, not here.
// If we reach here, it means LogicalHudiScan was incorrectly converted to
// PhysicalFileScan.
throw new RuntimeException("HUDI table should use PhysicalHudiScan instead of PhysicalFileScan. "
+ "This indicates a bug in the optimizer rules. "
+ "FileScan class: " + fileScan.getClass().getSimpleName());
default:
throw new RuntimeException("do not support DLA type " + ((HMSExternalTable) table).getDlaType());
}
Expand Down
8 changes: 8 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalHudiScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,14 @@ public LogicalFileScan withOperativeSlots(Collection<Slot> operativeSlots) {
operativeSlots, virtualColumns, groupExpression, Optional.of(getLogicalProperties()), cachedOutputs);
}

@Override
public LogicalFileScan withCachedOutput(List<Slot> cachedOutputs) {
return new LogicalHudiScan(relationId, (ExternalTable) table, qualifier,
selectedPartitions, tableSample, tableSnapshot, scanParams, incrementalRelation,
operativeSlots, virtualColumns, groupExpression, Optional.of(getLogicalProperties()),
Optional.of(cachedOutputs));
}

/**
* Set scan params for incremental read
*
Expand Down
Loading