Skip to content

[refactor] Remove decimal v1 related code from code base#6079

Merged
morningman merged 5 commits intoapache:masterfrom
yangzhg:remove_decimal_v1
Jul 7, 2021
Merged

[refactor] Remove decimal v1 related code from code base#6079
morningman merged 5 commits intoapache:masterfrom
yangzhg:remove_decimal_v1

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Jun 22, 2021

Proposed changes

remove ALL DECIMAL V1 type code , this is a part of #6073

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on ([refactor] Remove Decmial Type and rename DecmialV2 to Decimal #6073) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yangzhg yangzhg changed the title Remove decimal v1 [refactor] Remove decimal v1 related code from code base Jun 22, 2021
@yangzhg yangzhg force-pushed the remove_decimal_v1 branch 2 times, most recently from c149492 to e7f49c9 Compare June 24, 2021 01:57
@morningman morningman added the kind/refactor Issues or PRs to refactor code label Jun 29, 2021
@yangzhg yangzhg force-pushed the remove_decimal_v1 branch from 8075faa to e96ef05 Compare June 30, 2021 05:34
morningman
morningman previously approved these changes Jul 1, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morningman
morningman previously approved these changes Jul 1, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morningman
morningman previously approved these changes Jul 5, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/refactor Issues or PRs to refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants