Skip to content

fix stdfs link error in some gcc version#6090

Merged
yangzhg merged 1 commit intoapache:masterfrom
stdpain:fix_compile_fs
Jun 26, 2021
Merged

fix stdfs link error in some gcc version#6090
yangzhg merged 1 commit intoapache:masterfrom
stdpain:fix_compile_fs

Conversation

@stdpain
Copy link
Contributor

@stdpain stdpain commented Jun 24, 2021

Proposed changes

fix

../runtime/libRuntime.a(snapshot_loader.cpp.o): In function `doris::SnapshotLoader::move(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::shared_ptr<doris::Tablet>, bool)': /opt/soft/incubator-doris/be/src/runtime/snapshot_loader.cpp:433: undefined reference to `std::filesystem::remove_all(std::filesystem::__cxx11::path const&)' /opt/soft/incubator-doris/be/src/runtime/snapshot_loader.cpp:435: undefined reference to `std::filesystem::create_directory(std::filesystem::__cxx11::path const&)' ../runtime/libRuntime.a(snapshot_loader.cpp.o):(.gcc_except_table+0x83c): undefined reference to `typeinfo for std::filesystem::__cxx11::filesystem_error' ../runtime/libRuntime.a(snapshot_loader.cpp.o):(.gcc_except_table+0x878): undefined reference to `typeinfo for std::filesystem::__cxx11::filesystem_error' ../util/libUtil.a(broker_storage_backend.cpp.o): In function `std::filesystem::__cxx11::path::path<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::filesystem::__cxx11::path>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::filesystem::__cxx11::path::format)': /usr/local/include/c++/8.4.0/bits/fs_path.h:185: undefined reference to `std::filesystem::__cxx11::path::_M_split_cmpts()' ../util/libUtil.a(broker_storage_backend.cpp.o): In function `doris::BrokerStorageBackend::download(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': /opt/soft/incubator-doris/be/src/util/broker_storage_backend.cpp:58: undefined reference to `std::filesystem::remove(std::filesystem::__cxx11::path const&)' collect2: error: ld returned 1 exit status make[2]: *** [src/service/palo_be] Error 1 make[1]: *** [src/service/CMakeFiles/palo_be.dir/all] Error 2 make: *** [all] Error 2

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added approved Indicates a PR has been approved by one committer. kind/chore Issues or PRs related to compile and install area/compiler labels Jun 25, 2021
@yangzhg yangzhg merged commit dd455af into apache:master Jun 26, 2021
@stdpain stdpain deleted the fix_compile_fs branch June 27, 2021 12:47
stalary pushed a commit to stalary/doris that referenced this pull request Jun 28, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/compiler kind/chore Issues or PRs related to compile and install

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants