Skip to content

[Docs] ADD: fe-idea-dev.md add thrift version notice #6104

Merged
yangzhg merged 2 commits intoapache:masterfrom
stalary:doc_thrift
Jun 29, 2021
Merged

[Docs] ADD: fe-idea-dev.md add thrift version notice #6104
yangzhg merged 2 commits intoapache:masterfrom
stalary:doc_thrift

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Jun 28, 2021

Proposed changes

fe-idea-dev.md add thrift version notice,Prevent some users from experiencing compilation failures

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix complie error #6078) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@EmmyMiao87 EmmyMiao87 self-assigned this Jun 28, 2021
@EmmyMiao87 EmmyMiao87 added the kind/docs Categorizes issue or PR as related to documentation. label Jun 28, 2021
@EmmyMiao87 EmmyMiao87 changed the title ADD: fe-idea-dev.md add thrift version notice [Docs] ADD: fe-idea-dev.md add thrift version notice Jun 28, 2021
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Jun 28, 2021
@yangzhg yangzhg merged commit 513b1e7 into apache:master Jun 29, 2021
stalary added a commit to stalary/doris that referenced this pull request Jul 8, 2021
@stalary stalary deleted the doc_thrift branch May 8, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

complie error

3 participants