Skip to content

[Bug] Fix the bug of bucket shuffle join cause error paln#6172

Merged
morningman merged 3 commits intoapache:masterfrom
HappenLee:bug-fix
Jul 8, 2021
Merged

[Bug] Fix the bug of bucket shuffle join cause error paln#6172
morningman merged 3 commits intoapache:masterfrom
HappenLee:bug-fix

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

Fix the bug #6171

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Bug] Error plan in bucket shuffle join #6171) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

List<Column> leftDistributeColumns = ((HashDistributionInfo) leftDistribution).getDistributionColumns();
List<String> leftDistributeColumnNames = Lists.newArrayList();
for (Column col : leftDistributeColumns) {
leftDistributeColumnNames.add(leftTable.getName() + "-" + col.getName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used to "."

if (leftSlot.getTable() instanceof OlapTable) {
// table name in SlotRef is not the really name. `select * from test as t`
// table name in SlotRef is `t`, but here we need is `test`.
leftJoinColumnNames.add(leftSlot.getTable().getName() + "-" + leftSlot.getColumnName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used to '"."

EmmyMiao87
EmmyMiao87 previously approved these changes Jul 7, 2021
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87 EmmyMiao87 added approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug. labels Jul 7, 2021
@EmmyMiao87 EmmyMiao87 self-assigned this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Error plan in bucket shuffle join

3 participants