Skip to content

[UT] Fix CreateMaterializedViewStmtTest failed#6258

Merged
morningman merged 1 commit intoapache:masterfrom
morningman:fix_debug_ut
Jul 18, 2021
Merged

[UT] Fix CreateMaterializedViewStmtTest failed#6258
morningman merged 1 commit intoapache:masterfrom
morningman:fix_debug_ut

Conversation

@morningman
Copy link
Contributor

Proposed changes

In PR #6226, we open the debug level of unit test, it cause some
unexpected exception.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

In PR apache#6226, we open the debug level of unit test, it cause some
unexpected exception.
@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. kind/test labels Jul 17, 2021
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label Jul 17, 2021
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 92d41f9 into apache:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants