Skip to content

[Optimize][Clone] Take version count into consideration when choosing src replica for clone task#6513

Merged
morningman merged 5 commits intoapache:masterfrom
weizuo93:optimize-clone-task-replica-selector
Aug 30, 2021
Merged

[Optimize][Clone] Take version count into consideration when choosing src replica for clone task#6513
morningman merged 5 commits intoapache:masterfrom
weizuo93:optimize-clone-task-replica-selector

Conversation

@weizuo93
Copy link
Contributor

Proposed changes

Fix #6512

If there is missing replica for a tablet, clone task will be executed to restore missing replica from a healthy replica. Src replica selector will randomly choose a healthy replica as src replica.

It's better to choose the health replica with minmun version count as src replica so that it could avoid repetitive compaction task. In addition, replica with less version count is good for query performance.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2021
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit d5d8316 into apache:master Aug 30, 2021
@weizuo93 weizuo93 deleted the optimize-clone-task-replica-selector branch March 9, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/tablet-scheduler kind/improvement reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Optimize][Clone] Optimize clone task replica selector

3 participants