Support concurrent export of query results#6539
Merged
morningman merged 9 commits intoapache:masterfrom Sep 7, 2021
Merged
Conversation
morningman
reviewed
Sep 1, 2021
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/analysis/OutFileClause.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/planner/ExchangeNode.java
Outdated
Show resolved
Hide resolved
| } else { | ||
| _storage_type = TStorageBackendType::BROKER; | ||
| } | ||
| _fragment_instance_id.hi = 12345678987654321; |
Contributor
Author
There was a problem hiding this comment.
In order to be compatible with the old version of Fe and the new version of be
Contributor
There was a problem hiding this comment.
Add comment to explain.
BTW, I suggest to add FileNamePrefix column in the result of outfile operation. For easy to get full name of exported files. Such as:
+------------+-----------+-----------+-------------+------------------------------------------+
| FileNumber | TotalRows | FileSize | URL |FileNamePrefix |
+------------+-----------+-----------+-------------+------------------------------------------+
| 1 | 123605 | 361061014 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10325|
| 1 | 128180 | 374334318 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10326|
| 1 | 125156 | 365569023 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10327|
| 1 | 124096 | 362395588 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10328|
| 1 | 124862 | 364727515 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10329|
| 1 | 124520 | 363649600 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10330|
| 1 | 124447 | 363479285 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10331|
| 1 | 125134 | 365490611 | 127.0.0.1 |my_file2_46e9ef9b66924a79-92f887d43be10332|
+------------+-----------+-----------+-------------+------------------------------------------+
Contributor
Author
There was a problem hiding this comment.
It's not easy to add, there will be compatibility issues
This pr mainly supports
1. Export query result sets concurrently
2. Query result set export supports s3 protocol
Among them, there are several preconditions for concurrently exporting query result sets
1. Enable concurrent export variables
2. The query itself can be exported concurrently
(some queries containing sort nodes at the top level cannot be exported concurrently)
3. Export the s3 protocol used instead of the broker
After exporting the result set concurrently,
the file prefix is changed to outfile_{query_instance_id}_filenumber.{file_format}
3203362 to
29e5e79
Compare
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
approved these changes
Sep 6, 2021
Contributor
|
PR approved by at least one committer and no changes requested. |
Closed
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Feb 29, 2024
legacy planner impl PR: apache#6539
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Mar 1, 2024
legacy planner impl PR: apache#6539
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Mar 1, 2024
legacy planner impl PR: apache#6539
morrySnow
added a commit
that referenced
this pull request
Mar 4, 2024
legacy planner impl PR: #6539
yiguolei
pushed a commit
that referenced
this pull request
Mar 6, 2024
legacy planner impl PR: #6539
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pr mainly supports
Among them, there are several preconditions for concurrently exporting query result sets
(some queries containing sort nodes at the top level cannot be exported concurrently)
After exporting the result set concurrently,
the file prefix is changed to outfile_{query_instance_id}_filenumber.{file_format}
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.