-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Bug] Fix bug that The MetaObject lock design of fe would cause some problems with consistent meta when catalog do replay operation #6650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
here, we only need to check state of meta object when get write lock except the following conditions,
|
b499469 to
bc0069c
Compare
|
44ae4c7 to
d0324ae
Compare
| } else { | ||
| // not swap, the origin table is not used anymore, need to drop all its tablets. | ||
| Catalog.getCurrentCatalog().onEraseOlapTable(origTable, isReplay); | ||
| origTable.markDropped(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving markDropped() inside the db.dropTable() and catalog.onEraseOlapTable() method?
So that we don't need to call markDropped() every time along with these methods manually.
And also, add markUndropped() method to db.createTable() method to address the operation like modifyView or renameTable, etc.
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/http/rest/TableRowCountAction.java
Show resolved
Hide resolved
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...