Conversation
Contributor
Author
|
cc @caiconghui #6656 |
caiconghui
reviewed
Sep 15, 2021
| @Override | ||
| public int compare(Replica r1, Replica r2) { | ||
| long verCount1 = r1.getVersionCount() == -1 ? Integer.MAX_VALUE : r1.getVersionCount(); | ||
| long verCount2 = r2.getVersionCount() == -1 ? Integer.MAX_VALUE : r2.getVersionCount(); |
Contributor
There was a problem hiding this comment.
Integer.MAX_VALUE -> Long.MAX_VALUE
Contributor
Author
There was a problem hiding this comment.
This is intentional, because compare() return int. If I use Long.MAX_VALUE, it may be overflow.
Contributor
There was a problem hiding this comment.
the type of verCount is long, so I think we just need to return 1, -1, 0 to support bigger scope of version count value
caiconghui
reviewed
Sep 15, 2021
be/src/olap/tablet.cpp
Outdated
| set_last_base_compaction_failure_time(UnixMillis()); | ||
| DorisMetrics::instance()->base_compaction_request_failed->increment(1); | ||
| if (res != OLAP_ERR_BE_NO_SUITABLE_VERSION) { | ||
| DorisMetrics::instance()->base_compaction_request_failed->increment(1); |
Contributor
There was a problem hiding this comment.
Suggested change
| DorisMetrics::instance()->base_compaction_request_failed->increment(1); | |
| DorisMetrics::instance()->base_compaction_request_failed->increment(1); |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
force-pushed
the
sandbox_bugs
branch
from
6afb5ae to
02b71c5
Compare
github-actions
bot
removed
the
approved
morningman
force-pushed
the
sandbox_bugs
branch
from
02b71c5 to
c9ebd62
Compare
Member
|
LGTM |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ordercolumn inshow tabletresult. (Fix [Feature] Addordercolumn inSHOW TABLETstmt result #6658)SHOW PROC "/cluster_balance/cluster_load_stat"SHOW PROC "/statistic"to show COLOCATE_MISMATCH tablets (Fix [Feature] the health status of colocate table's tablet is not shown in show proc statistic #6663)show load where state='pending'can not be executed. (Fix [Bug]show load where state='pending'can not be executed. #6664)Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...