Implement the routine load process of Kafka on Backend #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Feb 27, 2019
| } | ||
|
|
||
| // delete TopicPartition finally | ||
| auto tp_deleter = [] (const std::vector<RdKafka::TopicPartition*>& vec) { |
Contributor
There was a problem hiding this comment.
Suggested change
| auto tp_deleter = [] (const std::vector<RdKafka::TopicPartition*>& vec) { | |
| auto tp_deleter = [&topic_partitions] () { |
| std::for_each(vec.begin(), vec.end(), | ||
| [](RdKafka::TopicPartition* tp1) { delete tp1; }); | ||
| }; | ||
| DeferOp delete_tp(std::bind<void>(tp_deleter, topic_partitions)); |
| return; | ||
| } | ||
|
|
||
| #define HANDLE_ERROR(stmt, err_msg) \ |
Contributor
There was a problem hiding this comment.
don't use macro here, you can create another function do following work, and this function call that function, and checks its return and handler error
| DeferOp delete_conf(std::bind<void>(conf_deleter, conf)); | ||
|
|
||
| std::string errstr; | ||
| #define SET_KAFKA_CONF(conf_key, conf_val) \ |
EmmyMiao87
reviewed
Feb 28, 2019
| public class RLTaskTxnCommitAttachment extends TxnCommitAttachment { | ||
|
|
||
| public enum RoutineLoadType { | ||
| public enum LoadSourceType { |
Contributor
There was a problem hiding this comment.
There is a LoadDataSourceTypeenum in package routineload. Using 'LoadDataSourceType' is better
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 19, 2019
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
morningman
added a commit
that referenced
this pull request
Apr 24, 2019
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the common part of stream load utilities from stream_load.cpp, such as StreamLoadContext, StreamLoadExecutor, move it to
runtime/stream_load/Implement the routine load task executor, and can consuming data via kafka client. All implementations are in
runtime/routine_load/