Skip to content

[Fix] Flink connector support json import and use httpclient to streamlaod#6740

Merged
hf200012 merged 21 commits intoapache:masterfrom
JNSimba:flink-connector-jsonhttpclient
Sep 28, 2021
Merged

[Fix] Flink connector support json import and use httpclient to streamlaod#6740
hf200012 merged 21 commits intoapache:masterfrom
JNSimba:flink-connector-jsonhttpclient

Conversation

@JNSimba
Copy link
Member

@JNSimba JNSimba commented Sep 24, 2021

Proposed changes

When the text is imported, there may be separators in the data;
Therefore, support json format import.
Need setting parameters (only json array format is provided, so it must be set in pairs)
sink.properties.format = json
sink.properties.strip_outer_array=true

And modify the HTTPURLConnection of streamload to Httpclient request

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix doris-flink-connecter数据换行配置不起作用 #6550 ) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The http client version should be upgraded to 4.5.13

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

hf200012
hf200012 previously approved these changes Sep 27, 2021
@minchowang
Copy link

Thanks @JNSimba for the nice contribution.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JNSimba Maybe we can add this to the

docs/zh-CN/extending-doris/flink-doris-connector.md

?

Add a simple instruction for this featuer?

@JNSimba
Copy link
Member Author

JNSimba commented Sep 28, 2021

Hi @JNSimba Maybe we can add this to the

docs/zh-CN/extending-doris/flink-doris-connector.md

?

Add a simple instruction for this featuer?

already add

Copy link
Contributor

@hf200012 hf200012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 28, 2021
@hf200012 hf200012 merged commit df5ba6b into apache:master Sep 28, 2021
@hf200012 hf200012 mentioned this pull request Sep 28, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/flink-connector reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doris-flink-connecter数据换行配置不起作用

4 participants