Modify interface #684
Merged
Modify interface #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
morningman
commented
Mar 4, 2019
morningman
commented
- Add batch submit interface
- Add Kafka Event callback to catch Kafka events
1. Add batch submit interface 2. Add Kafka Event callback to catch kafka events
imay
reviewed
Mar 4, 2019
| status.to_thrift(&t_status); | ||
| TStatus& t_status, const std::vector<TRoutineLoadTask>& tasks) { | ||
|
|
||
| for (auto& task : tasks) { |
Contributor
There was a problem hiding this comment.
Some tasks may be successful submitted, and some may be fail.
Is this OK?
Contributor
Author
There was a problem hiding this comment.
First, it is very unlikely to submit failed. And just make is simple here. Let FE handle the error now.(may be timeout).
It will be changed later if this is a big deal.
imay
reviewed
Mar 4, 2019
| if (t_info.__isset.max_interval_s) { | ||
| max_interval_s = t_info.max_interval_s; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
can you drop this empty line?
I think this is harmful to read code.
If there is no complex logic block, please don't add empty line
Contributor
Author
There was a problem hiding this comment.
I will put it to one line
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
morningman
added a commit
that referenced
this pull request
Mar 25, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
morningman
added a commit
that referenced
this pull request
Apr 4, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
morningman
added a commit
that referenced
this pull request
Apr 19, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
morningman
added a commit
that referenced
this pull request
Apr 24, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
1. Add batch submit interface 2. Add Kafka Event callback to catch Kafka events
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.