Put begin txn into task scheduler #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EmmyMiao87
commented
Mar 5, 2019
EmmyMiao87
commented
- fix the nesting lock of db and txn
- the txn of task will be init in task scheduler before take task from queue
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
morningman
requested changes
Mar 5, 2019
| } | ||
| } | ||
|
|
||
| public List<Long> getBackendIdsByCluster(String clusterName) throws MetaNotFoundException { |
Contributor
There was a problem hiding this comment.
We already have a method in SystemInfoService
| ConnectContext.get().getQualifiedUser(), | ||
| ConnectContext.get().getRemoteIP(), | ||
| routineLoadJob.getTableName()); | ||
| try { |
Contributor
There was a problem hiding this comment.
Check priv does not throw MetaNotFoundException
| public long getMinTaskBeId() throws LoadException { | ||
| public long getMinTaskBeId(String clusterName) throws LoadException { | ||
| List<Long> beIdsInCluster = new ArrayList<>(); | ||
| try { |
Contributor
There was a problem hiding this comment.
Use method in SystemInfoService
|
|
||
| abstract TRoutineLoadTask createRoutineLoadTask() throws LoadException, UserException; | ||
|
|
||
| public void setTxn() throws LabelAlreadyUsedException, BeginTransactionException, AnalysisException { |
Contributor
There was a problem hiding this comment.
better to name it 'beginTxn'?
morningman
approved these changes
Mar 5, 2019
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
morningman
pushed a commit
that referenced
this pull request
Mar 25, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
morningman
pushed a commit
that referenced
this pull request
Apr 4, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
morningman
pushed a commit
that referenced
this pull request
Apr 19, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
EmmyMiao87
added a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
morningman
pushed a commit
that referenced
this pull request
Apr 24, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
1. fix the nesting lock of db and txn 2. the txn of task will be init in task scheduler before take task from queue
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Sep 12, 2022
…pache#687) Some basic unit test for meta service * create_instance get_cluster * get_tablet_stats * begin_txn precommit_txn commit_txn there are more to be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.