[Memory] Add a method to get doris current memory usage and Limt memoey usage when consume #6979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangzhg
changed the title
yangzhg
force-pushed
the
get_current_mem
branch
from
abc2ab2 to
43a0fbc
Compare
yangzhg
changed the title
ans76
reviewed
Nov 1, 2021
ans76
reviewed
Nov 1, 2021
yangzhg
force-pushed
the
get_current_mem
branch
2 times, most recently
from
d145241 to
39781c6
Compare
|
lgtm % add tests for |
yangzhg
force-pushed
the
get_current_mem
branch
2 times, most recently
from
bec85ac to
6e8b55d
Compare
morningman
reviewed
Nov 4, 2021
morningman
reviewed
Nov 4, 2021
yangzhg
force-pushed
the
get_current_mem
branch
3 times, most recently
from
dc24a76 to
cf12d58
Compare
yangzhg
commented
Nov 15, 2021
| #if !defined(ADDRESS_SANITIZER) && !defined(LEAK_SANITIZER) && !defined(THREAD_SANITIZER) | ||
| doris::MemInfo::refresh_current_mem(); | ||
| #endif | ||
| sleep(10); |
yangzhg
commented
Nov 15, 2021
| if (MemInfo::current_mem() + bytes >= MemInfo::mem_limit()) { | ||
| return Status::MemoryLimitExceeded(fmt::format( | ||
| "{}: TryConsume failed, bytes={} process whole consumption={} mem limit={}", | ||
| label_, bytes, MemInfo::current_mem(), MemInfo::mem_limit())); |
Member
Author
There was a problem hiding this comment.
Status::MemoryLimitExceeded not MemTracker::MemLimitExceeded
Add all memory usage check when TryConsume memory
yangzhg
force-pushed
the
get_current_mem
branch
from
cf12d58 to
0a154d4
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a method to get Doris current memory usage, get Doris memory usage every 1 second.
This method used to limit the whole memory allocation in Doris
Add all memory usage check when
TryConsumememoryTypes of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...