Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Nov 12, 2021

Proposed changes

Introduce by pr #4359

VariableMgr.fillValue() method should not call in ExpressionFunctions.eval(), because in method analyzeImpl() of SysVariableDesc, it has been already called once.

If VariableMgr.fillValue() was called twice, the type of SysVariableDesc will become BigInt, which is incorrect.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Bug] Fix the incompatibility of sql mode between Doris and MySQL #7106 ) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720 xy720 changed the title save code [Bug] Fix the incompatibility of sql mode between Doris and MySQL Nov 12, 2021
@xy720 xy720 added area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/fix Categorizes issue or PR as related to a bug. labels Nov 12, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2021
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 74e8264 into apache:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix the incompatibility of sql mode between Doris and MySQL

2 participants