Clean timeout tablets channel in TabletWriterMgr #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Mar 11, 2019
imay
reviewed
Mar 11, 2019
be/src/runtime/tablet_writer_mgr.cpp
Outdated
| return Status::OK; | ||
| } | ||
|
|
||
| void* TabletWriterMgr::_tablets_channel_clean_thread_callback(void* arg) { |
Contributor
There was a problem hiding this comment.
you can remove this function and put this logical to lambda in start_bg_worker.
imay
reviewed
Mar 11, 2019
Co-Authored-By: kangkaisen <kangkaisen@apache.org>
imay
approved these changes
Mar 11, 2019
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Apr 24, 2019
platoneko
pushed a commit
to platoneko/doris
that referenced
this pull request
Oct 27, 2022
…emKv transaction (apache#718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #690
Add a config
streaming_load_max_duration_time_sec, a thread_tablets_channel_clean_threadand astd::unordered_map<TabletsChannelKey, time_t,TabletsChannelKeyHasher> _key_time_mapIf a tablets_channel alive time exceed the
streaming_load_max_duration_time_sec, we will erase the tablets_channel.This PR is testing because the test need a long time.