[feat](lateral-view) Support execution of lateral view stmt #7255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added
kind/feature
morningman
force-pushed
the
table_func
branch
2 times, most recently
from
7d2ee28 to
9f74ec5
Compare
morningman
force-pushed
the
table_func
branch
from
9f74ec5 to
d3b8470
Compare
EmmyMiao87
reviewed
Dec 9, 2021
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/analysis/LateralViewRef.java
Outdated
Show resolved
Hide resolved
| import java.io.File; | ||
| import java.util.UUID; | ||
|
|
||
| public class TableFunctionPlanTest { |
Contributor
There was a problem hiding this comment.
Please add some UT about explode_bitmap, explode_json_array_xxx
3 tasks
EmmyMiao87
reviewed
Dec 10, 2021
|
|
||
| return true; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please add examples of real data above two while(true)
| tuple_ptr = reinterpret_cast<Tuple*>(tuple_buffer); | ||
| } | ||
|
|
||
| pre_tuple_ptr = tuple_ptr; |
Contributor
There was a problem hiding this comment.
The logic of constructing a new line can be abstracted separately into a function
Contributor
Author
There was a problem hiding this comment.
I tried. But it has to pass a lot param to that new method, which seems not necessary.
morningman
force-pushed
the
table_func
branch
from
68f4cbd to
ded6e8b
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Design can be found in #6746
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...