Skip to content

Conversation

@caiconghui
Copy link
Contributor

@caiconghui caiconghui commented Dec 3, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…is from nullable tuple in outer join sql block
@caiconghui caiconghui changed the title [fix](select outer join) Make selected slotRef nullable when slotRef is from nullable tuple in outer join sql block [fix](select join) Make selected slotRef nullable when slotRef is from nullable tuple in outer join sql block Dec 3, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @EmmyMiao87

@morningman morningman added area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug. labels Dec 5, 2021
@morningman morningman self-assigned this Dec 5, 2021
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

PR approved by anyone and no changes requested.

@caiconghui caiconghui merged commit 8660bf6 into apache:master Dec 6, 2021
xinyiZzz pushed a commit to xinyiZzz/incubator-doris that referenced this pull request Dec 14, 2021
@caiconghui caiconghui deleted the outerjoin_bug branch March 12, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Execute left out join sql with group_concat function will cause be core

3 participants