Skip to content

Conversation

@xinyiZzz
Copy link
Contributor

Proposed changes

Close related #7412 (replace it with issue number if it exists).

The response is accessed when done->Run is called in transmit_data(),
give response a default value to avoid null pointers in high concurrency.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz xinyiZzz changed the title [BUG] [BRPC] fixed BE crash in SendRpcResponse when high concurrency [BUG] [RPC] fixed BE crash in SendRpcResponse when high concurrency Dec 16, 2021
@xinyiZzz xinyiZzz changed the title [BUG] [RPC] fixed BE crash in SendRpcResponse when high concurrency [BUG] [RPC] fix BE crash in SendRpcResponse when high concurrency Dec 16, 2021
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 16, 2021
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 7d4da7a into apache:master Dec 16, 2021
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request Dec 24, 2021
…che#7413)

The response is accessed when done->Run is called in transmit_data(),
give response a default value to avoid null pointers in high concurrency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] When high concurrency, BE crash reports MissingRequiredFields in SendRpcResponse

3 participants