Skip to content

Add comment to avoid modification for variable_length #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 2 commits into from
Mar 14, 2019
Merged

Add comment to avoid modification for variable_length #750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d82a70
Add comment to avoid modification for variable_length
lide-reed Mar 14, 2019
14494ba
Complete comment to avoid modification for variable_length
lide-reed Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions be/src/exprs/expr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,11 @@ int Expr::compute_results_layout(
data[i].variable_length = true;
} else if (exprs[i]->type().type == TYPE_DECIMAL) {
data[i].byte_size = get_byte_size(exprs[i]->type().type);

// Although the current decimal has a fix-length, for the
// same value, it will work out different hash value due to the
// different memory represent if the variable_length here is set
// to false, so we have to keep it.
data[i].variable_length = true;
} else {
data[i].byte_size = get_byte_size(exprs[i]->type().type);
Expand Down