Add persist operations for routine load job #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Mar 14, 2019
| columnsInfo = (LoadColumnsInfo) parseNode; | ||
| columnsInfo.analyze(analyzer); | ||
| } else if (parseNode instanceof Expr) { | ||
| importColumnsStmt = (ImportColumnsStmt) parseNode; |
Contributor
There was a problem hiding this comment.
why don't you analyze importColumnStmt
| } | ||
| wherePredicate = (Expr) parseNode; | ||
| wherePredicate.analyze(analyzer); | ||
| importWhereStmt = (ImportWhereStmt) parseNode; |
Contributor
There was a problem hiding this comment.
why don't you analyze importWhereStmt
| } | ||
|
|
||
| private void checkCustomProperties() throws AnalysisException { | ||
| private void checkLoadSourceProperties() throws AnalysisException { |
Contributor
There was a problem hiding this comment.
LoadSource or DataSource ?
| throw new AnalysisException(KAFKA_OFFSETS_PROPERTY + " could not be a empty string"); | ||
| } | ||
| String[] kafkaOffsetsStringList = kafkaOffsetsString.split(","); | ||
| if (kafkaOffsetsStringList.length != kafkaPartitionOffsets.size()) { |
Contributor
There was a problem hiding this comment.
if some partition has offset while others hasn't ?
| super(-1, LoadDataSourceType.KAFKA); | ||
| } | ||
|
|
||
| public KafkaRoutineLoadJob(Long id, String name, long dbId, long tableId, String brokerList, String topic) { |
Contributor
There was a problem hiding this comment.
Maybe id can be initialized by itself
| } | ||
|
|
||
| // init kafka routine load job | ||
| long id = Catalog.getInstance().getNextId(); |
| // when currentTotalNum is more then ten thousand or currentErrorNum is more then maxErrorNum | ||
| protected int currentErrorNum; | ||
| protected int currentTotalNum; | ||
| protected long currentErrorNum; |
Contributor
There was a problem hiding this comment.
Use int is enough. It will be reset after more then 10000
| import org.apache.doris.transaction.AbortTransactionException; | ||
| import org.apache.doris.transaction.TransactionException; | ||
| import org.apache.doris.transaction.TransactionState; | ||
| public abstract class TxnStateChangeListener { |
Contributor
There was a problem hiding this comment.
why change interface to abstract class？
morningman
force-pushed
the
kafka_backend
branch
from
5fdb023 to
27b42c1
Compare
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 19, 2019
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
morningman
added a commit
that referenced
this pull request
Apr 24, 2019
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.