Skip to content

Conversation

@zuochunwei
Copy link
Contributor

Proposed changes

  1. replace boost library relative classes & functions with hand writing implement
  2. avoid casting for get_ptr()
  3. COW and its derived class COWHelper both defined non-virtual member derived() , it is bad practice and should avoid doing like this
  4. i try to use deriving from std::unique_ptr to implement mutable_ptr, and deriving from std::shared_ptr to implement immutable_ptr,but it's very difficult to complete because will result in massive modifications

Close related #issue (replace it with issue number if it exists).

Describe the overview of changes, and introduce why we need it.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zuochunwei zuochunwei changed the title [refactor](common) eliminate class COW dependence on boost [vectorized][refactor](common) eliminate class COW dependence on boost Jan 4, 2022
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

PR approved by anyone and no changes requested.

++ref_counter;
}

void release_ref() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rethink here may cause mem leak? How boost::intrusive_ref_counter prevent the problem

@HappenLee HappenLee merged commit 4a213f2 into apache:vectorized Jan 5, 2022
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 13, 2022
Co-authored-by: zuochunwei <zuochunwei@meituan.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 13, 2022
Co-authored-by: zuochunwei <zuochunwei@meituan.com>
HappenLee pushed a commit that referenced this pull request Jan 17, 2022
Co-authored-by: zuochunwei <zuochunwei@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants