Remove colocate table meta when drop db #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
reviewed
Mar 15, 2019
| db.setClusterName(clusterName); | ||
| unprotectCreateDb(db); | ||
| editLog.logCreateDb(db); | ||
| Catalog.getInstance().getEditLog().logCreateDb(db); |
Contributor
Author
There was a problem hiding this comment.
It's order to make the test for catalog.createDb and catalog.dropDb write easily.
Contributor
There was a problem hiding this comment.
I think it isn't a good idea to use getInstance() here, because this may lead some error if another Catalog exist in system, and it is strange to call getInstance() to get itself.
In addition I think it is better to limit use of singleton as little as possible.
So, could you find another way to write unit test?
imay
approved these changes
Mar 17, 2019
platoneko
pushed a commit
to platoneko/doris
that referenced
this pull request
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #760