modify the replay logic of routine load job #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linoclapton
reviewed
Mar 16, 2019
| private static final int BASE_OF_ERROR_RATE = 10000; | ||
| private static final int DEFAULT_MAX_ERROR_NUM = (int) (BASE_OF_ERROR_RATE * 0.5); | ||
| private static final int ERROR_SAMPLE_NUM = 1000 * 10000; | ||
| private static final int DEFAULT_MAX_ERROR_NUM = 0; |
There was a problem hiding this comment.
Please do not set DEFAULT_MAX_ERROR_NUM to 0. The job which does not set this value will be paused when the first commit...
| * currentErrorRows and currentTotalRows is used for check error rate | ||
| * errorRows and totalRows are used for statistics | ||
| */ | ||
| protected long currentErrorRows; |
There was a problem hiding this comment.
please use int for currentErrorNum and currentTotalNum
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 19, 2019
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
morningman
added a commit
that referenced
this pull request
Apr 24, 2019
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.