Add http post feature for HttpClient #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Mar 19, 2019
| } | ||
|
|
||
| if(_header_list != nullptr) { | ||
| curl_slist_free_all(_header_list); |
|
|
||
| void set_post_body(const std::string& post_body) { | ||
| curl_easy_setopt(_curl, CURLOPT_POSTFIELDS, post_body.c_str()); | ||
| curl_easy_setopt(_curl, CURLOPT_POSTFIELDSIZE, (long)post_body.length()); |
Contributor
There was a problem hiding this comment.
post_body.data(), post_body.size()
be/src/http/http_client.h
Outdated
|
|
||
| void set_content_type(const std::string content_type) { | ||
| std::string scratch_str = "Content-Type: " + content_type; | ||
| _header_list = curl_slist_append(NULL, scratch_str.c_str()); |
Contributor
There was a problem hiding this comment.
if (_header_list != nullptr) {
curl_slist_free_all(_header_list);
}
| std::string request_body = "simple post body query"; | ||
| st = client.execute_post_request(request_body, &response); | ||
| ASSERT_TRUE(st.ok()); | ||
| ASSERT_EQ(response.length(), request_body.length()); |
Contributor
There was a problem hiding this comment.
ASSERT_STRCMP(.c_str(), .c_str())
imay
previously approved these changes
Mar 19, 2019
imay
approved these changes
Mar 19, 2019
platoneko
pushed a commit
to platoneko/doris
that referenced
this pull request
Oct 27, 2022
apache#773) * Implement drop instance * Fix drop cluster without comparing instance id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.