Add a cleaner bg thread to clean idle data consumer #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Mar 19, 2019
| _finished(false), | ||
| _cancelled(false) { | ||
| _cancelled(false), | ||
| _last_visit_time(0) { |
Contributor
There was a problem hiding this comment.
The initial last_visit_time is 0 ? Will it be clean in the beginning?
Contributor
Author
There was a problem hiding this comment.
No. the last_visit_time will be set when calling consumer's start(). And the clean thread can not see any active consumer, because active consumers are not in the pool.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
that referenced
this pull request
Mar 25, 2019
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 4, 2019
morningman
added a commit
that referenced
this pull request
Apr 19, 2019
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
morningman
added a commit
that referenced
this pull request
Apr 24, 2019
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.