[fix](lateral-view) Error analyze when lateral view + subquery rewrite #7824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the subquery is rewritten, the rewritten stmt needs to be reset (that is, the content of the first analyze semantic analysis is cleared), and then the rewritten stmt can be reAnalyzed. The lateral view ref in the previous implementation forgot to implement the reset function. This caused him to keep the first error message in the second analyze. Eventually, two duplicate tupleIds appear in the new stmt and are marked with different tuple. From the explain string, the following syntax will have an additional wrong join predicate. ``` Query: explain select k1 from test_explode lateral view explode_split(k2, ",") tmp as e1 where k1 in (select k3 from tbl1); Error equal join conjunct: `k3` = `k3` ``` This pr mainly adds the reset function of the lateral view to avoid possible errors in the second analyze when the lateral view and subquery rewrite occur at the same time.
EmmyMiao87
added
kind/fix
morningman
added a commit
that referenced
this pull request
Jan 28, 2022
…#7865) fix bugs of lateral view with CTE or where clause. The error case can be found in newly added tests in `TableFunctionPlanTest.java` But there are still some bugs not being fixed, so the unit test is annotated with @ignore This PR contains the change is #7824 : > Issue Number: close #7823 > > After the subquery is rewritten, the rewritten stmt needs to be reset > (that is, the content of the first analyze semantic analysis is cleared), > and then the rewritten stmt can be reAnalyzed. > > The lateral view ref in the previous implementation forgot to implement the reset function. > This caused him to keep the first error message in the second analyze. > Eventually, two duplicate tupleIds appear in the new stmt and are marked with different tuple. > From the explain string, the following syntax will have an additional wrong join predicate. > ``` > Query: explain select k1 from test_explode lateral view explode_split(k2, ",") tmp as e1 where k1 in (select k3 from tbl1); > Error equal join conjunct: `k3` = `k3` > ``` > > This pr mainly adds the reset function of the lateral view > to avoid possible errors in the second analyze > when the lateral view and subquery rewrite occur at the same time.
Contributor
|
closed, fixed it #7865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #7823
After the subquery is rewritten, the rewritten stmt needs to be reset
(that is, the content of the first analyze semantic analysis is cleared),
and then the rewritten stmt can be reAnalyzed.
The lateral view ref in the previous implementation forgot to implement the reset function.
This caused him to keep the first error message in the second analyze.
Eventually, two duplicate tupleIds appear in the new stmt and are marked with different tuple.
From the explain string, the following syntax will have an additional wrong join predicate.
This pr mainly adds the reset function of the lateral view
to avoid possible errors in the second analyze
when the lateral view and subquery rewrite occur at the same time.