Skip to content

Fix add_version () core dump on acquiring delta #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaoyli merged 1 commit into from
Mar 21, 2019
Merged

Fix add_version () core dump on acquiring delta #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/olap/olap_header.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ OLAPStatus OLAPHeader::add_version(Version version, VersionHash version_hash,
return OLAP_ERR_HEADER_ADD_VERSION;
}

int delta_id = 0;
int delta_id = -1;
for (int i = 0; i < delta_size(); ++i) {
if (delta(i).start_version() == version.first
&& delta(i).end_version() == version.second) {
Expand All @@ -246,7 +246,7 @@ OLAPStatus OLAPHeader::add_version(Version version, VersionHash version_hash,
// Try to add version to protobuf.
PDelta* new_delta = nullptr;
try {
if (segment_group_id == -1 || segment_group_id == 0) {
if (segment_group_id == -1 || delta_id == -1) {
// snapshot will use segment_group_id which equals minus one
new_delta = add_delta();
new_delta->set_start_version(version.first);
Expand Down