Release SegmentGroup reference count #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
associated issue is #690 |
imay
reviewed
Mar 22, 2019
| } | ||
| for (SegmentGroup* segment_group : _segment_group_vec) { | ||
| segment_group->release(); | ||
| } |
Contributor
There was a problem hiding this comment.
_garbage_collection and this code will release a segment group twice
Contributor
There was a problem hiding this comment.
why _new_segment_group_vec doesn't need release?
In streaming ingestion, segment group is set to be one in creation. Upon closing, reference count should to be released. Otherwise, file descriptor and segment group object in memory can not be freed.
Contributor
|
Do we still need to release |
Contributor
Author
If delta_writer has release segment group, OLAPTable::delete_pending_data is not necessary to release it. When add_pending_data to olap_table, reference count of SegmentGroup is not added by one. |
Contributor
|
@chaoyli OK. |
imay
approved these changes
Mar 22, 2019
imay
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In streaming ingestion, segment group is set to be one in creation.
Upon closing, reference count should to be released. Otherwise,
file descriptor and segment group object in memory can not be freed.