Add metrics for routine load #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
reviewed
Mar 23, 2019
| COUNTER_ROUTINE_LOAD_RECEIVED_BYTES = new LongCounterMetric("routine_load_receive_bytes", | ||
| "total received bytes of routine load"); | ||
| PALO_METRIC_REGISTER.addPaloMetrics(COUNTER_ROUTINE_LOAD_RECEIVED_BYTES); | ||
| COUNTER_ROUTINE_LOAD_ERROR_ROWS = new LongCounterMetric("routine_load_error_rows", |
Contributor
There was a problem hiding this comment.
Is it meaningful for our or user without group by job id? Or maybe COUNTER_ROUTINE_LOAD_ROWS + COUNTER_ROUTINE_LOAD_ERROR_ROWS is more meaningful?
Contributor
Author
There was a problem hiding this comment.
I think each job's loaded rows or error rows should be saved in each job.
This metrics are for a global perspective of system runtime overview.
I use COUNTER_ROUTINE_LOAD_ERROR_ROWS to monitor if there are too many error rows.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 25, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
morningman
added a commit
that referenced
this pull request
Mar 25, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 4, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
morningman
added a commit
that referenced
this pull request
Apr 4, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
morningman
added a commit
that referenced
this pull request
Apr 19, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Apr 23, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
morningman
added a commit
that referenced
this pull request
Apr 24, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
imay
pushed a commit
that referenced
this pull request
Apr 28, 2019
* Add metrics for routine load * limit the max number of routine load task in backend to 10 * Fix bug that some partitions will no be assigned
mrhhsg
pushed a commit
to mrhhsg/doris
that referenced
this pull request
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.