[Vectorized][Feature] Support mysql external table insert into stm #7979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappenLee
reviewed
Feb 8, 2022
Contributor
HappenLee
left a comment
HappenLee
left a comment
There was a problem hiding this comment.
some problem need to change
| #include "vec/sink/vtablet_sink.h" | ||
|
|
||
| #include "vec/sink/vmysql_table_writer.h" | ||
| namespace doris { |
| int num_columns = _vec_output_expr_ctxs.size(); | ||
|
|
||
| for (int i = 0; i < num_columns; ++i) { | ||
| auto column_ptr = block.get_by_position(i).column->convert_to_full_column_if_const(); |
Contributor
There was a problem hiding this comment.
do convert before call insert_row
|
|
||
| for (int i = 0; i < num_columns; ++i) { | ||
| auto column_ptr = block.get_by_position(i).column->convert_to_full_column_if_const(); | ||
| auto type_ptr = block.get_by_position(i).type; |
| switch (_vec_output_expr_ctxs[i]->root()->result_type()) { | ||
| case TYPE_BOOLEAN: { | ||
| auto& data = assert_cast<const vectorized::ColumnUInt8&>(*column).get_data(); | ||
| fmt::format_to(_insert_stmt_buffer, "{}", std::to_string(data[row])); |
| case TYPE_VARCHAR: { | ||
| const auto& string_val = | ||
| assert_cast<const vectorized::ColumnString&>(*column).get_data_at(row); | ||
| if (string_val.data == nullptr) { |
| fmt::format_to(_insert_stmt_buffer, "{}", "NULL"); | ||
| } | ||
| } else { | ||
| char* buf = new char[2 * string_val.size + 1]; |
|
|
||
| // Insert this to MySQL server | ||
| std::string insert_stmt = to_string(_insert_stmt_buffer); | ||
| LOG(INFO) << insert_stmt; |
Contributor
There was a problem hiding this comment.
do not log each insert query
| fmt::format_to(_insert_stmt_buffer, "{}", ")"); | ||
|
|
||
| // Insert this to MySQL server | ||
| std::string insert_stmt = to_string(_insert_stmt_buffer); |
Contributor
There was a problem hiding this comment.
try to reduce the mem alloc
| RETURN_IF_ERROR(DataSink::prepare(state)); | ||
| // Prepare the exprs to run. | ||
| RETURN_IF_ERROR(VExpr::prepare(_output_expr_ctxs, state, _row_desc, _mem_tracker)); | ||
| std::stringstream title; |
Contributor
There was a problem hiding this comment.
use format to replace stringstream
HappenLee
reviewed
Feb 14, 2022
be/src/runtime/mysql_table_writer.h
Outdated
|
|
||
| #include "common/status.h" | ||
|
|
||
| #include <fmt/format.h> |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #7978
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...