Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Feb 8, 2022

Proposed changes

Issue Number: close #7971

Problem Summary:

Add check if grouping function column in all in group by list

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (Yes)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman
Copy link
Contributor

Please add ut in QueryPlanTest for this case

@yangzhg
Copy link
Member Author

yangzhg commented Feb 10, 2022

Please add ut in QueryPlanTest for this case

done!

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 11, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yangzhg yangzhg merged commit ee26cd2 into apache:master Feb 12, 2022
@yangzhg yangzhg deleted the fix_group branch February 12, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] (grouping set) Unexpected exception: bitIndex < 0: -1

2 participants