Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

Issue Number: close #7998

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 10, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@HappenLee HappenLee merged commit a4e7c76 into apache:master Feb 11, 2022
@xiaokang
Copy link
Contributor

@BiteTheDDDDt Should the following license comment for python be removed?

// This is taken from the python search string function doing string search (substring)
// using an optimized boyer-moore-horspool algorithm.
// http://hg.python.org/cpython/file/6b6c79eba944/Objects/stringlib/fastsearch.h

@BiteTheDDDDt
Copy link
Contributor Author

@BiteTheDDDDt Should the following license comment for python be removed?

// This is taken from the python search string function doing string search (substring) // using an optimized boyer-moore-horspool algorithm. // http://hg.python.org/cpython/file/6b6c79eba944/Objects/stringlib/fastsearch.h

yes, and seems like should add apache license. Do you want add a pull request to fix it?

@BiteTheDDDDt BiteTheDDDDt deleted the opt_seatch branch January 20, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimization for string_search

3 participants