[fix](compatibility) Fix compatibility issue of PRowBatch and some tablet sink bugs #8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
changed the title
yangzhg
reviewed
Feb 11, 2022
be/src/exec/tablet_sink.cpp
Outdated
| auto st = channel->add_row(tuple, tablet_id); | ||
| if (!st.ok()) { | ||
| mark_as_failed(channel, st.get_error_msg(), tablet_id); | ||
| mark_as_failed(channel.get(), st.get_error_msg(), tablet_id); |
Member
There was a problem hiding this comment.
Why not change mark_as_failed signature to accept shared_ptr ?
Contributor
Author
There was a problem hiding this comment.
I think it is not necessary, and it will cause extra shared ptr copy.
Member
There was a problem hiding this comment.
But I don't think it's a good practice to mix smart pointers and raw pointers. When we use smart pointers, we already imply that object ownership is managed by smart pointers instead of accessing raw pointers.
Contributor
Author
There was a problem hiding this comment.
OK, I will change it
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
1. set both tuple_offsets and new_tuple_offsets in PRowBatch for compatibility 2. set FE config `repair_slow_replica` default to false Avoid impacting the load process after upgrading. Eg, if there are only 2 replicas, one is with high version count. After upgrade, that replica will be set to bad, so that the load process will be stopped because only 1 replica is alive.
morningman
force-pushed
the
tuple_offsets_compatible
branch
from
86c5ca8 to
fb21ee0
Compare
github-actions
bot
removed
the
approved
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
tuple_offsetsandnew_tuple_offsetsin PRowBatch for compatibilityrepair_slow_replicadefault to falseAvoid impacting the load process after upgrading.
Eg, if there are only 2 replicas, one is with high version count. After upgrade,
that replica will be set to bad, so that the load process will be stopped
because only 1 replica is alive.
close_wait()Forget to set
add_batch_finishflag after the last rpc finished.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...