[Refactor] Remove version hash from BE and related test in BE #8027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
force-pushed
the
remove_version_hash
branch
from
0de752e to
2361579
Compare
morningman
reviewed
Feb 12, 2022
be/src/agent/task_worker_pool.cpp
Outdated
| tablet_info.schema_hash = tablet->schema_hash(); | ||
| tablet_info.version = create_tablet_req.version; | ||
| tablet_info.version_hash = create_tablet_req.version_hash; | ||
| // Useless but it is a required field i TTabletInfo |
Contributor
There was a problem hiding this comment.
Suggested change
| // Useless but it is a required field i TTabletInfo | |
| // Useless but it is a required field in TTabletInfo |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.