Skip to content

Bug-fix for some wrong logic #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lide-reed merged 1 commit into from
Mar 25, 2019
Merged

Bug-fix for some wrong logic #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/util/es_scroll_query.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ std::string ESScrollQueryBuilder::build(const std::map<std::string, std::string>
}
es_query_dsl.AddMember("_source", source_node, allocator);
}
int size = atoi(properties.at(ESScanReader::BATCH_SIZE).c_str());
int size = atoi(properties.at(ESScanReader::KEY_BATCH_SIZE).c_str());
rapidjson::Value sort_node(rapidjson::kArrayType);
rapidjson::Value field("_doc", allocator);
sort_node.PushBack(field, allocator);
Expand Down
2 changes: 0 additions & 2 deletions be/test/util/es_scan_reader_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ class RestSearchScrollAction : public HttpHandler {
std::string post_body = req->get_request_body();
rapidjson::Document post_doc;
post_doc.Parse<0>(post_body.c_str());
int size = 1;
std::string scroll_id;
if (!post_doc.HasMember("scroll_id")) {
HttpChannel::send_reply(req,HttpStatus::NOT_FOUND, "invalid scroll request");
Expand Down Expand Up @@ -166,7 +165,6 @@ class RestClearScrollAction : public HttpHandler {
std::string post_body = req->get_request_body();
rapidjson::Document post_doc;
post_doc.Parse<0>(post_body.c_str());
int size = 1;
std::string scroll_id;
if (!post_doc.HasMember("scroll_id")) {
HttpChannel::send_reply(req,HttpStatus::NOT_FOUND, "invalid scroll request");
Expand Down