-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](memory) fix olap table scan and sink memory usage problem #8451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](memory) fix olap table scan and sink memory usage problem #8451
Conversation
|
LGTM, but there are 2 more things:
|
|
Hi @morningman, Thanks for your quick response!
Test environment: Table schema: Test steps:
Result:
I will try to do the same things for the vectorized code. |
|
@morningman volap_scan_node.cpp is done. The test result is almost the same as non-vectorized version. |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…em (#8451) Due to unlimited queue in OlapScanNode and NodeChannel, memory usage can be very large for reading and writing large table, e.g 'insert into tableB select * from tableA'.
…em (apache#8451) Due to unlimited queue in OlapScanNode and NodeChannel, memory usage can be very large for reading and writing large table, e.g 'insert into tableB select * from tableA'.
Proposed changes
Issue Number: NA
Problem Summary:
Due to unlimited queue in OlapScanNode and NodeChannel, memory usage can be very large for reading and writting large table, e.g 'insert into tableB select * from tableA'.
Checklist(Required)
Further comments