-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](cold-hot) support remote storage #8532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengxiangyu
requested changes
Mar 21, 2022
docs/en/sql-reference/sql-statements/Data Definition/CREATE TABLE.md
Outdated
Show resolved
Hide resolved
docs/en/sql-reference/sql-statements/Data Definition/CREATE TABLE.md
Outdated
Show resolved
Hide resolved
docs/zh-CN/sql-reference/sql-statements/Administration/SHOW REMOTE STORAGES.md
Show resolved
Hide resolved
docs/zh-CN/sql-reference/sql-statements/Administration/SHOW REMOTE STORAGES.md
Outdated
Show resolved
Hide resolved
docs/zh-CN/sql-reference/sql-statements/Data Definition/CREATE TABLE.md
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Outdated
Show resolved
Hide resolved
pengxiangyu
requested changes
Mar 24, 2022
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/catalog/RemoteStorageMgr.java
Outdated
Show resolved
Hide resolved
Change-Id: I7c1b0fcdcea3123413064232445a03fb76342fe6
Change-Id: Id6fd861166eb7c2431fe9abb4be8cea74137ffb6
Change-Id: I2d0599aa7c0e369cce965e00dace3d52908a8a7b
Change-Id: I7a71111a5e4fa9c324c6ede1a16cff766bebd446
pengxiangyu
approved these changes
Mar 28, 2022
Contributor
pengxiangyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
Backup Restore has also defined similar remote storage logic. And Cold Hot defines another one. Could we unify these concepts? |
Contributor
Author
|
This PR is closed, please refer to #8808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #8531
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...