-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](OlapScanner)fix bitmap or hll's OOM #8764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ea33000
fix typo
e573d62
fix typo
f9fd2c9
Merge branch 'master' of github.com:SleepyBear96/incubator-doris
0bc3e41
Merge branch 'apache:master' into master
SleepyBear96 8217371
bitmap oom
1b232cb
bitmap oom
4d94096
Merge branch 'master' of github.com:SleepyBear96/incubator-doris
5056b9b
bitmap oom
5d7b614
bitmap oom fix
f10f02e
bitmap oom fix
SleepyBear96 6cdc89b
Update olap_scanner.cpp
SleepyBear96 91bf413
Update object_pool.h
SleepyBear96 98b139b
Update config.h
SleepyBear96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,6 +54,11 @@ class ObjectPool { | |
| for (Element& elem : _objects) elem.delete_fn(elem.obj); | ||
| _objects.clear(); | ||
| } | ||
|
|
||
| uint64_t size() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| std::lock_guard<SpinLock> l(_lock); | ||
| return _objects.size(); | ||
| } | ||
|
|
||
| void acquire_data(ObjectPool* src) { | ||
| _objects.insert(_objects.end(), src->_objects.begin(), src->_objects.end()); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment for this new config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.