Skip to content

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Mar 31, 2022

Proposed changes

  1. support suite block to specify multiple groups.
  2. TestAction support compare result to iterator, local file and http stream.
  3. support print teamcity service message.
  4. abandon the logical: generate groovy file for sql file
  5. support 3 levels parrallel: script file, suite block, thread action
  6. support specify JAVA_OPTS for boot shell
  7. avoid jvm metaspace oom
  8. use -d to run the suite in some directories, instead of -g. and -g is used to specify groups

already update demo in the chinese document and demo suites

Checklist(Required)

  1. Does it affect the original behavior: (Yes)
  2. Has unit tests been added: (No Need)
  3. Has document been added or modified: (Yes)
  4. Does it need to update dependencies: (Yes)
  5. Are there any changes that cannot be rolled back: (Yes)

@EmmyMiao87

@924060929 924060929 force-pushed the regression-test2 branch 2 times, most recently from cfa21e2 to 5f55e58 Compare March 31, 2022 16:54

## CI/CD的支持
### TeamCity
可以使用--teamcity开启TeamCity Service Message. `-Dteamcity.enableStdErr=false`可以让错误日志也打印到stdout中,方便按顺序分析日志。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果开启 --teamcity 的话,输出的文件是在哪里?以及在teamcity 上需要什么特殊的配置嘛?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要输出文件。除了配置启动命令,teamcity不需要修改什么。框架会打印teamcity的能识别的事件日志到标准输出流,teamcity在启动进程后会自动识别标准输出流中的日志

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯我的意思就是把配置 teamcity 流水线的这个步骤说一下。这样大家都可以按照这个步骤配置 ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了

return "##teamcity[testStdErr name='${suiteContext.flowName}' out='${escape(msg)}' flowId='${suiteContext.flowId}' timestamp='${timestamp}']"
}

// static void testSuiteStarted(ScriptContext scriptContext) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it directly ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

--clean) CLEAN=1 ; shift ;;
--run) RUN=1 ; shift ;;
--clean) CLEAN=1 ; shift ;;
--teamcity) TEAMCITY=1 ; shift ;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--teamcity) TEAMCITY=1 ; shift ;;
--teamcity) TEAMCITY=1 ; shift ;;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

--run) RUN=1 ; shift ;;
--clean) CLEAN=1 ; shift ;;
--teamcity) TEAMCITY=1 ; shift ;;
--run) RUN=1 ; shift ;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--run) RUN=1 ; shift ;;
--run) RUN=1 ; shift ;;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@EmmyMiao87 EmmyMiao87 added kind/improvement dev/backlog waiting to be merged in future dev branch labels Apr 1, 2022
@EmmyMiao87
Copy link
Contributor

The test failed. Maybe you should rebase the code ~

@924060929
Copy link
Contributor Author

The test failed. Maybe you should rebase the code ~

done

EmmyMiao87
EmmyMiao87 previously approved these changes Apr 1, 2022
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 1, 2022
Copy link
Contributor

@EmmyMiao87 EmmyMiao87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2022
@924060929 924060929 merged commit decdc8e into apache:master Apr 1, 2022
@924060929 924060929 deleted the regression-test2 branch April 2, 2022 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/backlog waiting to be merged in future dev branch kind/improvement kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants