Skip to content

Conversation

@qzsee
Copy link
Contributor

@qzsee qzsee commented Apr 3, 2022

Proposed changes

Issue Number: close #8814

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman
Copy link
Contributor

Please verify your email address to run GitHub Actions workflows

You may need to verify your email address at: https://github.com/settings/emails
Otherwise, it won't trigger checks

@cambyzju
Copy link
Contributor

cambyzju commented Apr 6, 2022

hi qzsee,

I also try to fix #issues/8814, please review:
#8822

actually max has the same bug as min.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test in regression-test.

@qzsee
Copy link
Contributor Author

qzsee commented Apr 6, 2022

hi qzsee,

I also try to fix #issues/8814, please review: #8822

actually max has the same bug as min.

oh, sorry I didn't realize you commited that before

@qzsee qzsee closed this Apr 6, 2022
@gj-zhang gj-zhang mentioned this pull request Apr 13, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] min and avg window function not work well.

4 participants